Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSdoc/TS fix of EllipsoidTangentPlane.fromPoints #9227

Merged
merged 3 commits into from
Nov 24, 2020
Merged

JSdoc/TS fix of EllipsoidTangentPlane.fromPoints #9227

merged 3 commits into from
Nov 24, 2020

Conversation

zoran995
Copy link
Contributor

@zoran995 zoran995 commented Nov 7, 2020

The EllipsoidTangentPlane.fromPoints misses a return type, it creates a new instance of EllipsoidTangentPlane. Missed to report this in #8926.

@cesium-concierge
Copy link

Thanks for the pull request @zoran995!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Nov 24, 2020

Thanks @zoran995!

@hpinkos hpinkos merged commit 8bd440d into CesiumGS:master Nov 24, 2020
@zoran995 zoran995 deleted the patch-1 branch November 24, 2020 16:23
@midnight-dev
Copy link

@hpinkos @zoran995 Hey guys. I realize this is a bit of a nitpick, but could one of you correct the minor typo in the changelog regarding this PR? (CI skip)

... which didn't listed a return type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zoran995 @cesium-concierge @hpinkos @midnight-dev